smaheshwar-pltr commented on PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#issuecomment-2585317026
Want to strongly highlight for folks reviewing (@kevinjqliu + @Fokko?) that I've **not** changed `WRITE_OBJECT_STORE_PARTITIONED_PATHS_DEFAULT` to `False` even though it's a similar change that intends to improves object store performance. I'm very open to discuss/change this (I'll update this PR name + description or put up a new one if so). So do we want to do this? My thinking was: after reading through https://github.com/apache/iceberg/pull/11112 it seems there was a strong case for supporting partition values in paths. When I thought about that, I realised that users might be relying on storage layout and files constituting partitions lying in the same directory - maybe just so that they can inspect storage to see how their files are *actually* laid out at a given point in time, especially in the context of partition evolution. On the other hand, maybe we should make this change to *discourage* reliance on file storage layout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
