smaheshwar-pltr commented on code in PR #1509:
URL: https://github.com/apache/iceberg-python/pull/1509#discussion_r1912071614


##########
tests/integration/test_writes/test_partitioned_writes.py:
##########
@@ -297,8 +297,8 @@ def 
test_object_storage_location_provider_excludes_partition_path(
     tbl = _create_table(
         session_catalog=session_catalog,
         
identifier=f"default.arrow_table_v{format_version}_with_null_partitioned_on_col_{part_col}",
-        # write.object-storage.partitioned-paths defaults to True
-        properties={"format-version": str(format_version), 
TableProperties.OBJECT_STORE_ENABLED: True},
+        # Both write.object-storage.enabled and 
write.object-storage.partitioned-paths default to True

Review Comment:
   Just changing this one integration test to test that it's now the default; 
I've kept `test_writes::test_object_storage_data_files` unchanged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to