soumya-ghosh commented on PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#issuecomment-2251212180
Thanks @kevinjqliu @HonahX for your review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kevinjqliu commented on PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#issuecomment-2251167083
@soumya-ghosh Merged! Thanks for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
kevinjqliu merged PR #956:
URL: https://github.com/apache/iceberg-python/pull/956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ice
HonahX commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1690519566
##
tests/table/test_init.py:
##
@@ -689,7 +689,7 @@ def test_update_metadata_add_snapshot(table_v2: Table) ->
None:
snapshot_id=25,
parent_snapsh
soumya-ghosh commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1689346998
##
tests/table/test_init.py:
##
@@ -689,7 +689,7 @@ def test_update_metadata_add_snapshot(table_v2: Table) ->
None:
snapshot_id=25,
parent_
HonahX commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1689261546
##
tests/catalog/test_sql.py:
##
@@ -1274,6 +1275,7 @@ def test_commit_table(catalog: SqlCatalog,
table_schema_nested: Schema, table_id
assert new_schema
soumya-ghosh commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1688483539
##
tests/catalog/test_glue.py:
##
@@ -707,6 +707,7 @@ def test_commit_table_update_schema(
test_catalog.create_namespace(namespace=database_name)
ta
soumya-ghosh commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1688482718
##
tests/table/test_init.py:
##
@@ -598,7 +598,7 @@ def test_apply_set_properties_update(table_v2: Table) ->
None:
base_metadata = table_v2.metadata
soumya-ghosh commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1688481435
##
pyiceberg/table/__init__.py:
##
@@ -1178,10 +1178,15 @@ def update_table_metadata(
"""
context = _TableMetadataUpdateContext()
new_metadata
kevinjqliu commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1688471128
##
pyiceberg/table/__init__.py:
##
@@ -1178,10 +1178,15 @@ def update_table_metadata(
"""
context = _TableMetadataUpdateContext()
new_metadata =
soumya-ghosh commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1687699314
##
tests/table/test_init.py:
##
@@ -689,7 +689,7 @@ def test_update_metadata_add_snapshot(table_v2: Table) ->
None:
snapshot_id=25,
parent_
soumya-ghosh commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1687693813
##
pyiceberg/table/__init__.py:
##
@@ -1178,10 +1178,15 @@ def update_table_metadata(
"""
context = _TableMetadataUpdateContext()
new_metadata
HonahX commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1687489596
##
pyiceberg/table/__init__.py:
##
@@ -1178,10 +1178,15 @@ def update_table_metadata(
"""
context = _TableMetadataUpdateContext()
new_metadata = base
HonahX commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1687497023
##
tests/table/test_init.py:
##
@@ -689,7 +689,7 @@ def test_update_metadata_add_snapshot(table_v2: Table) ->
None:
snapshot_id=25,
parent_snapsh
kevinjqliu commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1687344048
##
pyiceberg/table/__init__.py:
##
@@ -1178,10 +1178,15 @@ def update_table_metadata(
"""
context = _TableMetadataUpdateContext()
new_metadata =
15 matches
Mail list logo
