HonahX commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1689261546
##########
tests/catalog/test_sql.py:
##########
@@ -1274,6 +1275,7 @@ def test_commit_table(catalog: SqlCatalog,
table_schema_nested: Schema, table_id
assert new_schema
assert new_schema == update._apply()
assert new_schema.find_field("b").field_type == IntegerType()
+ assert updated_table_metadata.last_updated_ms > last_updated_ms
Review Comment:
Could we also add similar checks to unit tests for `update_table_metadata`?
For example:
https://github.com/apache/iceberg-python/blob/dceedfac4ec072ee4da99bf02dc93c1d27be45a9/tests/table/test_init.py#L597-L684
https://github.com/apache/iceberg-python/blob/dceedfac4ec072ee4da99bf02dc93c1d27be45a9/tests/table/test_init.py#L753-L761
##########
tests/table/test_init.py:
##########
@@ -689,7 +689,7 @@ def test_update_metadata_add_snapshot(table_v2: Table) ->
None:
snapshot_id=25,
parent_snapshot_id=19,
sequence_number=200,
- timestamp_ms=1602638573590,
+ timestamp_ms=1602638593590,
Review Comment:
[Minor] Could you please revert the change if it is not necessary? It will
be great if we can keep only the necessary changes in a Pull Request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
