HonahX commented on code in PR #956:
URL: https://github.com/apache/iceberg-python/pull/956#discussion_r1690519566
##########
tests/table/test_init.py:
##########
@@ -689,7 +689,7 @@ def test_update_metadata_add_snapshot(table_v2: Table) ->
None:
snapshot_id=25,
parent_snapshot_id=19,
sequence_number=200,
- timestamp_ms=1602638573590,
+ timestamp_ms=1602638593590,
Review Comment:
Ah I see. The previous value collides with the example table's
`last_udpated_ms` and thus make update_table_metadata thinks we need a new
timestamp. Thanks for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
