Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-19 Thread via GitHub
ZENOTME commented on code in PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1892659133 ## tests/test_transforms.py: ## @@ -988,608 +997,367 @@ def _test_projection(lhs: Optional[UnboundPredicate[L]], rhs: Optional[UnboundPr raise ValueErr

Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-19 Thread via GitHub
ZENOTME commented on code in PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1892659133 ## tests/test_transforms.py: ## @@ -988,608 +997,367 @@ def _test_projection(lhs: Optional[UnboundPredicate[L]], rhs: Optional[UnboundPr raise ValueErr

Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-19 Thread via GitHub
ZENOTME commented on code in PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1892659133 ## tests/test_transforms.py: ## @@ -988,608 +997,367 @@ def _test_projection(lhs: Optional[UnboundPredicate[L]], rhs: Optional[UnboundPr raise ValueErr

Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1886615423 ## tests/test_transforms.py: ## @@ -988,608 +997,367 @@ def _test_projection(lhs: Optional[UnboundPredicate[L]], rhs: Optional[UnboundPr raise ValueError

Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-16 Thread via GitHub
Fokko merged PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-11 Thread via GitHub
sungwy commented on code in PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1881033971 ## tests/test_transforms.py: ## @@ -988,608 +997,367 @@ def _test_projection(lhs: Optional[UnboundPredicate[L]], rhs: Optional[UnboundPr raise ValueErro

Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-10 Thread via GitHub
Fokko commented on code in PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1879026523 ## pyiceberg/transforms.py: ## @@ -985,7 +985,7 @@ def _truncate_number_strict( elif isinstance(pred, BoundGreaterThanOrEqual): return GreaterThan(Re