sungwy commented on code in PR #1422:
URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1881033971
##########
tests/test_transforms.py:
##########
@@ -988,608 +997,367 @@ def _test_projection(lhs:
Optional[UnboundPredicate[L]], rhs: Optional[UnboundPr
raise ValueError(f"Comparing unrelated: {lhs} <> {rhs}")
+def _assert_projection_strict(
+ pred: BooleanExpression,
+ transform: Transform[S, T],
+ expected_type: type[BooleanExpression],
+ expected_human_str: Optional[str] = None,
+) -> None:
+ result = transform.strict_project(name="name", pred=pred)
+
+ assert type(result) is expected_type or AlwaysFalse
Review Comment:
nit: I found it a bit confusing that we were defining the expected_type as
`AlwaysFalse` when actually `None` was being returned by `strict_project`, but
maybe the alternative of making `expected_type` `Optional` is more confusing 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
