pvary commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2248770983
> > Could you please create the backport PR to the other Flink versions?
>
> @pvary Should we have 2 backport PRs one for 1.17 and 1.18 or is it fine
to do it in a single PR?
venkata91 commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2248441890
> Could you please create the backport PR to the other Flink versions?
@pvary Should we have 2 backport PRs one for 1.17 and 1.18 or is it fine to
do it in a single PR?
pvary commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2246926879
Merged to main.
Thanks for the PR @venkata91!
Could you please create the backport PR to the other Flink versions? The PR
could be generated like this:
```
git diff ^ | se
pvary merged PR #10548:
URL: https://github.com/apache/iceberg/pull/10548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
pvary commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2245398205
> @pvary should this change be ported to other flink versions like `1.17`
and `1.18`?
In a follow-up backport pr
--
This is an automated message from the Apache Git Service.
To r
venkata91 commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2243603565
@pvary should this change be ported to other flink versions like `1.17` and
`1.18`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
venkata91 commented on code in PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#discussion_r1686993453
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSpecExecSupport.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Fou
pvary commented on code in PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#discussion_r1686427190
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSpecExecSupport.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundat
pvary commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2242713133
@venkata91: Nicely done, just a few small nits, and then I am fine with the
change.
I will give @stevenzwu a few days, if he wants to chime in. If not, then we
could move forward.
pvary commented on code in PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#discussion_r1686382902
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSpecExecSupport.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundat
pvary commented on code in PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#discussion_r1686382506
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSpecExecSupport.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundat
venkata91 commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2239850208
Gentle ping for reviews cc @pvary @stevenzwu Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
venkata91 commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2230058127
> @venkata91: How can we be sure that the tests are exercising the
speculative execution code path?
>
> Does any of the tests reads some splits multiple times, and use the resul
venkata91 commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2218838952
> @venkata91: How can we be sure that the tests are exercising the
speculative execution code path?
>
> Does any of the tests reads some splits multiple times, and use the resul
pvary commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2207052299
@venkata91: How can we be sure that the tests are exercising the speculative
execution code path?
Does any of the tests reads some splits multiple times, and use the result
of the
venkata91 commented on code in PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#discussion_r1659558108
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/AbstractIcebergEnumerator.java:
##
@@ -93,6 +98,28 @@ public void handleSourceEvent(in
venkata91 commented on PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2197923268
cc @stevenzwu for review. Should this change also be made in other Flink
versions like Flink-1.17 and Flink-1.18?
--
This is an automated message from the Apache Git Service.
To res
17 matches
Mail list logo
