venkata91 commented on PR #10548: URL: https://github.com/apache/iceberg/pull/10548#issuecomment-2230058127
> @venkata91: How can we be sure that the tests are exercising the speculative execution code path? > > Does any of the tests reads some splits multiple times, and use the result of the faster one? > > I think it would be useful to have a test demonstrating that the behavior works, to prevent disabling it by an unrelated change by accident. @pvary Added an integration test to verify the tasks are speculated and produces the expected output. PTAL. btw, should this change also be made in other Flink versions like Flink-1.17 and Flink-1.18? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
