venkata91 commented on code in PR #10548:
URL: https://github.com/apache/iceberg/pull/10548#discussion_r1659558108
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/AbstractIcebergEnumerator.java:
##########
@@ -93,6 +98,28 @@ public void handleSourceEvent(int subtaskId, SourceEvent
sourceEvent) {
}
}
+ @Override
+ public void handleSourceEvent(int subTaskId, int attemptNumber, SourceEvent
sourceEvent) {
+ if (sourceEvent instanceof SplitRequestEvent) {
+ if (attemptNumber > 0 &&
splitIdAssignedBySubtask.containsKey(subTaskId)) {
+ LOG.info(
+ "Received request split event from subtask {} attempt {}",
subTaskId, attemptNumber);
+ enumeratorContext.assignSplit(splitIdAssignedBySubtask.get(subTaskId),
subTaskId);
+ } else if (attemptNumber == 0) {
Review Comment:
Refactored the PR based on the comments above. This is no more applicable.
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/AbstractIcebergEnumerator.java:
##########
@@ -93,6 +98,28 @@ public void handleSourceEvent(int subtaskId, SourceEvent
sourceEvent) {
}
}
+ @Override
+ public void handleSourceEvent(int subTaskId, int attemptNumber, SourceEvent
sourceEvent) {
Review Comment:
Thanks for pointing it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
