Fokko commented on PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#issuecomment-2061828760
Thanks for fixing this @MehulBatra Much appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Fokko merged PR #592:
URL: https://github.com/apache/iceberg-python/pull/592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
MehulBatra commented on PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#issuecomment-2061776890
> @MehulBatra I've removed an unrelated change, I think #612 addresses the
issue that you ran into
sounds good!
--
This is an automated message from the Apache Git Servic
Fokko commented on PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#issuecomment-2061773917
@MehulBatra I've removed an unrelated change, I think
https://github.com/apache/iceberg-python/pull/612/ addresses the issue that you
ran into
--
This is an automated message from t
Fokko commented on code in PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1569167115
##
tests/expressions/test_literals.py:
##
@@ -277,8 +277,7 @@ def test_decimal_to_decimal_conversion() -> None:
def test_timestamp_to_date() -> None:
epoch_lit
Fokko commented on code in PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1569166271
##
tests/expressions/test_literals.py:
##
@@ -277,8 +277,7 @@ def test_decimal_to_decimal_conversion() -> None:
def test_timestamp_to_date() -> None:
epoch_lit
Fokko commented on code in PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1568690611
##
tests/test_types.py:
##
@@ -560,13 +560,13 @@ def test_deserialization_struct() -> None:
def test_str_struct(simple_struct: StructType) -> None:
-assert
MehulBatra commented on code in PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1568694815
##
tests/test_types.py:
##
@@ -560,13 +560,13 @@ def test_deserialization_struct() -> None:
def test_str_struct(simple_struct: StructType) -> None:
-as
MehulBatra commented on PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#issuecomment-2061051645
> Looks good @MehulBatra Left one small suggestion.
>
> Could you also remove `required=False` from `mkdocs/docs/api.md`. Since
this is now default, I think we should remove
MehulBatra commented on code in PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1568694815
##
tests/test_types.py:
##
@@ -560,13 +560,13 @@ def test_deserialization_struct() -> None:
def test_str_struct(simple_struct: StructType) -> None:
-as
Fokko commented on code in PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1559924873
##
tests/test_types.py:
##
@@ -560,13 +560,13 @@ def test_deserialization_struct() -> None:
def test_str_struct(simple_struct: StructType) -> None:
-assert
11 matches
Mail list logo
