Fokko commented on code in PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1559924873
##########
tests/test_types.py:
##########
@@ -560,13 +560,13 @@ def test_deserialization_struct() -> None:
def test_str_struct(simple_struct: StructType) -> None:
- assert str(simple_struct) == "struct<1: required_field: required string
(this is a doc), 2: optional_field: required int>"
+ assert str(simple_struct) == "struct<1: required_field: required string
(this is a doc), 2: optional_field: optional int>"
Review Comment:
This seems a bit confusing, the name of the field is `required_field`, but
it is actually optional.
##########
pyiceberg/types.py:
##########
@@ -24,10 +24,10 @@
... NestedField(1, "required_field", StringType(), True),
... NestedField(2, "optional_field", IntegerType())
... ))
- 'struct<1: required_field: optional string, 2: optional_field: optional
int>'
+ 'struct<1: required_field: required string, 2: optional_field: optional
int>'
Review Comment:
Nice one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
