Fokko commented on code in PR #592:
URL: https://github.com/apache/iceberg-python/pull/592#discussion_r1569167115
##########
tests/expressions/test_literals.py:
##########
@@ -277,8 +277,7 @@ def test_decimal_to_decimal_conversion() -> None:
def test_timestamp_to_date() -> None:
epoch_lit =
TimestampLiteral(int(datetime.datetime.fromisoformat("1970-01-01T01:23:45.678").timestamp()
* 1_000_000))
date_lit = epoch_lit.to(DateType())
-
- assert date_lit.value == 0
+ assert abs(date_lit.value) == 0
Review Comment:
```suggestion
assert date_lit.value == 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
