Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
rdblue commented on PR #9423: URL: https://github.com/apache/iceberg/pull/9423#issuecomment-1912276296 Merged! Thanks for all the work on this, @nastra! It's great to have this done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
rdblue merged PR #9423: URL: https://github.com/apache/iceberg/pull/9423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467810466 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -107,6 +108,21 @@ case class Extend

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467808305 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467807645 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467647161 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467525182 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -40,6 +46,19 @@ case class RewriteViewCommands(spar

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467415508 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467293803 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-26 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467405697 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467293803 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467284844 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467283709 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467282732 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -107,6 +108,21 @@ case class Extend

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1467280647 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,33 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466949343 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466944474 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466943097 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466937074 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466935932 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466935932 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -886,6 +886,202 @@ private String viewName(String viewName) {

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466927874 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -107,6 +108,21 @@ case class Extend

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466925935 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -40,6 +46,19 @@ case class RewriteViewCommands(spar

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466895600 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466899911 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,33 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466898401 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,33 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466898131 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,33 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466895600 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466416756 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466163328 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466157026 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466157026 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466150091 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,32 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466150091 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,32 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466145042 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466013897 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,32 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1466012277 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,32 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465986604 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -350,39 +350,21 @@ public void readFromViewReferencingAnotherView(

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-25 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465984985 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache So

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465973319 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465573215 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465565118 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465564320 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465562137 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -350,39 +350,21 @@ public void readFromViewReferencingAnotherView(

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465559938 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache So

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465558301 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -151,7 +179,7 @@ case class ResolveViews(spark: SparkSessi

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465557799 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,32 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465553150 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +61,32 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465547862 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465544090 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465543334 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464767785 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464764583 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464764253 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-24 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464613485 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +62,10 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464146096 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -139,24 +139,9 @@ public void readFromMultipleViews() throws NoSu

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464145827 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464145346 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464144880 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1464142918 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1463848914 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1463815754 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -59,6 +62,10 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1456586630 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1456546379 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1455627217 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1455299682 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1455100866 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1455090708 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1455041489 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1455012760 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454958750 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454951834 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-17 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454928120 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454226741 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454225836 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454224355 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454223964 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454221454 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454218584 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.scala: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache S

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454213115 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454214282 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454213115 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apac

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454179584 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454089362 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454089362 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454087181 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1454030078 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -40,6 +42,11 @@ case class RewriteViewCommands(spar

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1453840484 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1453833185 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -40,6 +42,11 @@ case class RewriteViewCommands(spar

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
rdblue commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1453833185 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -40,6 +42,11 @@ case class RewriteViewCommands(spar

Re: [PR] Spark: Support creating views via SQL [iceberg]

2024-01-16 Thread via GitHub
nastra commented on code in PR #9423: URL: https://github.com/apache/iceberg/pull/9423#discussion_r1453312170 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCheck.scala: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat