rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1453833185
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -40,6 +42,11 @@ case class RewriteViewCommands(spark: SparkSession) extends
Rule[LogicalPlan] wi
override def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUp
{
case DropView(ResolvedView(resolved), ifExists) =>
DropIcebergView(resolved, ifExists)
+
+ case CreateView(r@ResolvedView(_), userSpecifiedColumns, comment,
properties,
+ originalText, query, allowExisting, replace) =>
+ CreateIcebergView(r, userSpecifiedColumns, comment, properties,
originalText,
Review Comment:
Why not use the `ResolvedIdentifier` here? It looks like other rules expect
the `UnresolvedIdentifier` to be replaced with a resolved identifier, which is
already produced by `ResolvedView`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
