Re: [PR] Spark: Don't allow branch_ usage with TIMESTAMP AS OF [iceberg]

2024-03-31 Thread via GitHub
nastra merged PR #10059: URL: https://github.com/apache/iceberg/pull/10059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Spark: Don't allow branch_ usage with TIMESTAMP AS OF [iceberg]

2024-03-30 Thread via GitHub
nastra commented on code in PR #10059: URL: https://github.com/apache/iceberg/pull/10059#discussion_r1545207874 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java: ## @@ -448,6 +448,12 @@ public void testInvalidTimeTravelAgainstBranchIdentifierWithAs

Re: [PR] Spark: Don't allow branch_ usage with TIMESTAMP AS OF [iceberg]

2024-03-29 Thread via GitHub
amogh-jahagirdar commented on code in PR #10059: URL: https://github.com/apache/iceberg/pull/10059#discussion_r1545052196 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java: ## @@ -448,6 +448,12 @@ public void testInvalidTimeTravelAgainstBranchIdenti

Re: [PR] Spark: Don't allow branch_ usage with TIMESTAMP AS OF [iceberg]

2024-03-29 Thread via GitHub
singhpk234 commented on code in PR #10059: URL: https://github.com/apache/iceberg/pull/10059#discussion_r1544949819 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java: ## @@ -448,6 +448,12 @@ public void testInvalidTimeTravelAgainstBranchIdentifierWi