amogh-jahagirdar commented on code in PR #10059:
URL: https://github.com/apache/iceberg/pull/10059#discussion_r1545052196
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -448,6 +448,12 @@ public void
testInvalidTimeTravelAgainstBranchIdentifierWithAsOf() {
() -> sql("SELECT * FROM %s.branch_b1 VERSION AS OF %s",
tableName, snapshotId))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Cannot do time-travel based on both table identifier and
AS OF");
+
+ // using branch_b1 in the table identifier and TIMESTAMP AS OF
+ Assertions.assertThatThrownBy(
+ () -> sql("SELECT * FROM %s.branch_b1 TIMESTAMP AS OF %s",
tableName, snapshotId))
Review Comment:
Good catch @singhpk234 I totally missed this. Would be good to fix this test
to pass a timestamp just so someone reading it isn't confused!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
