singhpk234 commented on code in PR #10059:
URL: https://github.com/apache/iceberg/pull/10059#discussion_r1544949819
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -448,6 +448,12 @@ public void
testInvalidTimeTravelAgainstBranchIdentifierWithAsOf() {
() -> sql("SELECT * FROM %s.branch_b1 VERSION AS OF %s",
tableName, snapshotId))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Cannot do time-travel based on both table identifier and
AS OF");
+
+ // using branch_b1 in the table identifier and TIMESTAMP AS OF
+ Assertions.assertThatThrownBy(
+ () -> sql("SELECT * FROM %s.branch_b1 TIMESTAMP AS OF %s",
tableName, snapshotId))
Review Comment:
[minor] should we pass actual timestamp instead of snapshotId ? though I
agree this error is hit before the timestamp parsing so testing like this is
also sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
