flyrain merged PR #486:
URL: https://github.com/apache/iceberg-python/pull/486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
himadripal commented on PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#issuecomment-1981317217
@flyrain and @Fokko thank you for reviewing this. Please take a look again
when you can.
--
This is an automated message from the Apache Git Service.
To respond to the message
Fokko commented on code in PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#discussion_r1514258300
##
pyiceberg/catalog/rest.py:
##
@@ -289,12 +291,25 @@ def auth_url(self) -> str:
else:
return self.url(Endpoints.get_token, prefixed=False)
flyrain commented on code in PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#discussion_r1513528807
##
pyiceberg/catalog/rest.py:
##
@@ -289,12 +291,25 @@ def auth_url(self) -> str:
else:
return self.url(Endpoints.get_token, prefixed=False)
himadripal commented on code in PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#discussion_r1513012494
##
pyiceberg/catalog/rest.py:
##
@@ -289,12 +291,25 @@ def auth_url(self) -> str:
else:
return self.url(Endpoints.get_token, prefixed=Fals
Fokko commented on PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#issuecomment-1978136175
@himadripal Can you fix the issue here? And update the doc in the same PR?
Apart from that, this looks good. Thanks for working on this 👍
--
This is an automated message from the Ap
flyrain commented on code in PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#discussion_r1512006182
##
pyiceberg/catalog/rest.py:
##
@@ -289,12 +291,25 @@ def auth_url(self) -> str:
else:
return self.url(Endpoints.get_token, prefixed=False)
himadripal commented on PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#issuecomment-1975262865
Requesting for review one this one please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
himadripal commented on PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#issuecomment-1972523776
@Fokko @syun64 @flyrain @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
