himadripal commented on code in PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#discussion_r1513012494
##########
pyiceberg/catalog/rest.py:
##########
@@ -289,12 +291,25 @@ def auth_url(self) -> str:
else:
return self.url(Endpoints.get_token, prefixed=False)
+ def _extract_optional_oauth_params(self) -> Dict[str, str]:
+ set_of_optional_params = {AUDIENCE, RESOURCE}
Review Comment:
Yes, we can but scope has default value and others ones do not have in
iceberg Java. Also to keep parity with Java version I have kept scope separate.
I was thinking once we consolidate these params in Java, we can then do it
here. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
