Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-04 Thread via GitHub
ajantha-bhat commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1477293784 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-03 Thread via GitHub
rdblue commented on PR #9466: URL: https://github.com/apache/iceberg/pull/9466#issuecomment-1925450414 Thanks, @bryanck! This is looking great and I'm excited to get the next steps in. Also thanks to @fqaiser94 for reviewing! -- This is an automated message from the Apache Git Serv

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-03 Thread via GitHub
rdblue merged PR #9466: URL: https://github.com/apache/iceberg/pull/9466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476417816 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476325368 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476307388 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476289111 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476285119 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476280534 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476276022 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476270090 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476264616 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476258875 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-02 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476250156 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475300294 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475298017 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475297691 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475296932 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475296279 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475294454 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475293606 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475293311 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475292656 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475291920 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475291601 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475290713 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SchemaUtils.java: ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475285952 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475284866 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475279732 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475198634 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1475196684 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1474907692 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-02-01 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1474904035 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-27 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1468709394 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-27 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1468708917 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-27 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1468708459 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-27 Thread via GitHub
fqaiser94 commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1468699416 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-27 Thread via GitHub
fqaiser94 commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1464225023 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-22 Thread via GitHub
fqaiser94 commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1462661503 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-22 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1462366234 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/PartitionedAppendWriter.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-22 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1462294450 ## kafka-connect/build.gradle: ## @@ -30,3 +30,30 @@ project(":iceberg-kafka-connect:iceberg-kafka-connect-events") { useJUnitPlatform() } } + +project(":ice

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-22 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1462292947 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/PartitionedAppendWriter.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-21 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460954285 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordWriter.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-21 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460951937 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-21 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460948481 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-20 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460715863 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java: ## @@ -0,0 +1,478 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-20 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460713886 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/PartitionedAppendWriter.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-20 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460713684 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-20 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460711350 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-20 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460701487 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-20 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460700886 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-20 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1460700772 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1454266632 ## kafka-connect/build.gradle: ## @@ -30,3 +30,30 @@ project(":iceberg-kafka-connect:iceberg-kafka-connect-events") { useJUnitPlatform() } } + +project(":ic

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1454263685 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1454263039 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1454260672 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1454234210 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1454226357 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,511 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1454221144 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordWrapper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on PR #9466: URL: https://github.com/apache/iceberg/pull/9466#issuecomment-1894702324 I stripped out the delta writers and record converter, along with related tests and config. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-16 Thread via GitHub
bryanck commented on PR #9466: URL: https://github.com/apache/iceberg/pull/9466#issuecomment-1894239101 Sure, thanks, I'll scale down this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451801651 ## kafka-connect/build.gradle: ## @@ -30,3 +30,30 @@ project(":iceberg-kafka-connect:iceberg-kafka-connect-events") { useJUnitPlatform() } } + +project(":ice

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451801429 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java: ## @@ -0,0 +1,478 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451800872 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordWrapper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451800701 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordWriter.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451800555 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,511 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451800122 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/PartitionedAppendWriter.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451799486 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451799323 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451799004 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451798927 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451798132 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451797484 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451797289 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451797043 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451796523 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Kafka Connect: Sink connector with data writers and converters [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1451796402 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/Utilities.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF