bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1468708459
########## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriterFactory.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.connect.data; + +import java.util.List; +import java.util.concurrent.atomic.AtomicReference; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Table; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.connect.IcebergSinkConfig; +import org.apache.iceberg.exceptions.NoSuchTableException; +import org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting; +import org.apache.iceberg.types.Types.StructType; +import org.apache.iceberg.util.Tasks; +import org.apache.kafka.connect.errors.DataException; +import org.apache.kafka.connect.sink.SinkRecord; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class IcebergWriterFactory { + + private static final Logger LOG = LoggerFactory.getLogger(IcebergWriterFactory.class); + + private final Catalog catalog; + private final IcebergSinkConfig config; + + public IcebergWriterFactory(Catalog catalog, IcebergSinkConfig config) { + this.catalog = catalog; + this.config = config; + } + + public RecordWriter createWriter( + String tableName, SinkRecord sample, boolean ignoreMissingTable) { + TableIdentifier identifier = TableIdentifier.parse(tableName); + Table table; + try { + table = catalog.loadTable(identifier); + } catch (NoSuchTableException nst) { + if (config.autoCreateEnabled()) { + table = autoCreateTable(tableName, sample); + } else if (ignoreMissingTable) { + return new NoOpWriter(); + } else { + throw nst; + } + } + + return new IcebergWriter(table, tableName, config); + } + + @VisibleForTesting + Table autoCreateTable(String tableName, SinkRecord sample) { + StructType structType; + if (sample.valueSchema() == null) { + structType = + SchemaUtils.inferIcebergType(sample.value(), config) + .orElseThrow(() -> new DataException("Unable to create table from empty object")) + .asStructType(); + } else { + structType = SchemaUtils.toIcebergType(sample.valueSchema(), config).asStructType(); + } + + org.apache.iceberg.Schema schema = new org.apache.iceberg.Schema(structType.fields()); + TableIdentifier identifier = TableIdentifier.parse(tableName); + + List<String> partitionBy = config.tableConfig(tableName).partitionBy(); + PartitionSpec spec; + try { + spec = SchemaUtils.createPartitionSpec(schema, partitionBy); + } catch (Exception e) { + LOG.error( + "Unable to create partition spec {}, table {} will be unpartitioned", + partitionBy, + identifier, + e); + spec = PartitionSpec.unpartitioned(); + } + + PartitionSpec partitionSpec = spec; + AtomicReference<Table> result = new AtomicReference<>(); + Tasks.range(1) + .retry(IcebergSinkConfig.CREATE_TABLE_RETRIES) + .run( + notUsed -> { + try { + result.set(catalog.loadTable(identifier)); + } catch (NoSuchTableException e) { + result.set( + catalog.createTable( + identifier, schema, partitionSpec, config.autoCreateProps())); + } Review Comment: I considered that and I agree it would have been a nice solution to reduce the contention. The issue is that you need to have the schema's field IDs assigned when you write the data. You need some type of coordination to prevent different workers from using the same ID for different fields. The catalog is acting as that coordinator currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
