bryanck commented on code in PR #9466: URL: https://github.com/apache/iceberg/pull/9466#discussion_r1476250156
########## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.connect.data; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.Arrays; +import java.util.List; +import org.apache.iceberg.Table; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.connect.IcebergSinkConfig; +import org.apache.iceberg.data.Record; +import org.apache.iceberg.io.TaskWriter; +import org.apache.iceberg.io.WriteResult; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.kafka.connect.errors.DataException; +import org.apache.kafka.connect.sink.SinkRecord; + +public class IcebergWriter implements RecordWriter { + private final Table table; + private final String tableName; + private final IcebergSinkConfig config; + private final List<WriterResult> writerResults; + + // FIXME: update this when the record converter is added + // private RecordConverter recordConverter; + private TaskWriter<Record> writer; + + public IcebergWriter(Table table, String tableName, IcebergSinkConfig config) { + this.table = table; + this.tableName = tableName; + this.config = config; + this.writerResults = Lists.newArrayList(); + initNewWriter(); + } + + private void initNewWriter() { + this.writer = Utilities.createTableWriter(table, tableName, config); + // FIXME: update this when the record converter is added + // this.recordConverter = new RecordConverter(table, config); + } + + @Override + public void write(SinkRecord record) { + try { + // TODO: config to handle tombstones instead of always ignoring? + if (record.value() != null) { + Record row = convertToRow(record); + + // FIXME: add CDC operation support + + writer.write(row); + } + } catch (Exception e) { + throw new DataException( Review Comment: The sink won't stop initially, but the task will fail. Depending on the platform (Strimzi, Confluent, etc) the task will restart and the source topic partitions rebalanced across the tasks. If the failure is not recoverable then after a number of retries the sink will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
