Re: [PR] Kafka Connect: Record converters [iceberg]

2024-12-02 Thread via GitHub
anmol commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1867182926 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ## @@ -52,20 +51,22 @@ public IcebergWriter(Table table, String tableName

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-10-15 Thread via GitHub
anmol commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1802251828 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ## @@ -52,20 +51,22 @@ public IcebergWriter(Table table, String tableName

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-10-14 Thread via GitHub
ajantha-bhat commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1799683954 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ## @@ -52,20 +51,22 @@ public IcebergWriter(Table table, String ta

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-10-14 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1799677923 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ## @@ -52,20 +51,22 @@ public IcebergWriter(Table table, String tableNa

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-10-14 Thread via GitHub
anmol commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1799060030 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java: ## @@ -52,20 +51,22 @@ public IcebergWriter(Table table, String tableName

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-21 Thread via GitHub
bryanck merged PR #9641: URL: https://github.com/apache/iceberg/pull/9641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-21 Thread via GitHub
bryanck commented on PR #9641: URL: https://github.com/apache/iceberg/pull/9641#issuecomment-2012955949 I was planning on merging this, unless someone wants to give more feedback, cc @fqaiser94 @danielcweeks -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-12 Thread via GitHub
fqaiser94 commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1521874230 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-12 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1521807811 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-12 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1521780274 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-12 Thread via GitHub
ajreid21 commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1521739300 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-12 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1521621409 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-12 Thread via GitHub
bryanck commented on PR #9641: URL: https://github.com/apache/iceberg/pull/9641#issuecomment-1991814651 > What's expected to be included in the next kafka-connect PR? > > Asking b/c I'm doing some work on implementing zombie-fencing in tabular/iceberg-kafka-connect currently and we ma

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-12 Thread via GitHub
fqaiser94 commented on PR #9641: URL: https://github.com/apache/iceberg/pull/9641#issuecomment-1991551990 What's expected to be included in the next kafka-connect PR? Asking b/c I'm doing some work on implementing zombie-fencing in tabular/iceberg-kafka-connect currently and we may w

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-12 Thread via GitHub
fqaiser94 commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1521338858 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-09 Thread via GitHub
bryanck commented on PR #9641: URL: https://github.com/apache/iceberg/pull/9641#issuecomment-1987029928 I believe I've addressed all comments, LMK if there is anything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-09 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1518698166 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-09 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1518697497 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordProjection.java: ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-09 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1518697202 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/RecordConverterTest.java: ## @@ -0,0 +1,907 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-09 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1518696748 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/RecordConverterTest.java: ## @@ -0,0 +1,907 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-09 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1518694023 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/RecordConverterTest.java: ## @@ -0,0 +1,907 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-09 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1518693577 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-06 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1515539847 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-06 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1515525033 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-06 Thread via GitHub
bryanck commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1515525033 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Kafka Connect: Record converters [iceberg]

2024-03-06 Thread via GitHub
fqaiser94 commented on code in PR #9641: URL: https://github.com/apache/iceberg/pull/9641#discussion_r1515260098 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache Software Founda