anmol commented on code in PR #9641:
URL: https://github.com/apache/iceberg/pull/9641#discussion_r1799060030
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java:
##########
@@ -52,20 +51,22 @@ public IcebergWriter(Table table, String tableName,
IcebergSinkConfig config) {
private void initNewWriter() {
this.writer = Utilities.createTableWriter(table, tableName, config);
- // FIXME: update this when the record converter is added
- // this.recordConverter = new RecordConverter(table, config);
+ this.recordConverter = new RecordConverter(table, config);
Review Comment:
@bryanck - Is there any plan to add CDC support? We used the tabular
connector and looks like there can be an edge case when committing the equality
deletes by the Coordinator.
A scenario which we are facing -
Inserts and corresponding deletes are committed as the same commit(metadata
having same Seq Num) to iceberg in form of Equality deletes (not posDeletes
because the inserts went in a previous uncommitted commit), when there are very
close insert and delete records ( example - records which are inserted and
deleted by an Oracle Procedure to implement rejection in a specific business
use case). This is intermittent and not easy to reproduce. We have created an
issue for the same -
https://github.com/tabular-io/iceberg-kafka-connect/issues/303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
