huaxingao commented on PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#issuecomment-2486300125
@RussellSpitzer There are some conflict files. If I rebase, it will also
pick up changes for Spark3.5, so I opened a new
[PR](https://github.com/apache/iceberg/pull/11583). I will pi
huaxingao closed pull request #11257: Initial Support for Spark 4.0 preview
URL: https://github.com/apache/iceberg/pull/11257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
RussellSpitzer commented on PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#issuecomment-2407643346
I'm ready for V2 :) Let me know when you have those changes up. I'm trying
to review this on a per commit basis because the diff is so large :)
--
This is an automated message
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1797108343
##
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java:
##
@@ -108,14 +108,14 @@ public static Object[][] parameters()
huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1794383706
##
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java:
##
@@ -108,14 +108,14 @@ public static Object[][] parameters() {
huaxingao commented on PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#issuecomment-2403559725
@RussellSpitzer Thanks for your review! I have addressed the comments and
switched back to Preview1, along with reverting a few changes I made for
Preview2/snapshot. I switched back t
huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1794322243
##
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java:
##
@@ -108,14 +108,14 @@ public static Object[][] parameters() {
huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1794322082
##
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -138,6 +138,7 @@ public class TestRewriteDataFilesAction e
huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1794321900
##
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownInRowLevelOperations.java:
##
@@ -260,7 +267,12 @@ privat
huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1794321692
##
spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSqlExtensionsAstBuilder.scala:
##
@@ -30,7 +30,7 @@ import org.
huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1794321464
##
gradle/libs.versions.toml:
##
@@ -47,6 +47,7 @@ flink120 = { strictly = "1.20.0"}
google-libraries-bom = "26.47.0"
guava = "33.3.0-jre"
hadoop2 = "2.7.3"
+had
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793776491
##
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreaming.java:
##
@@ -302,4 +303,12 @@ private MemoryStream newMemoryStream(i
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793770367
##
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java:
##
@@ -108,14 +108,14 @@ public static Object[][] parameters()
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793767329
##
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -138,6 +138,7 @@ public class TestRewriteDataFilesAct
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793766774
##
spark/v4.0/spark/src/main/scala/org/apache/spark/sql/stats/ThetaSketchAgg.scala:
##
@@ -119,3 +122,12 @@ case class ThetaSketchAgg(
compactSketch.toByt
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793758286
##
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownInRowLevelOperations.java:
##
@@ -260,7 +267,12 @@ p
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793751529
##
spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSqlExtensionsAstBuilder.scala:
##
@@ -30,7 +30,7 @@ import
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793748247
##
spark/v4.0/build.gradle:
##
@@ -33,6 +34,7 @@ configure(sparkProjects) {
force
"com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793743752
##
gradle/libs.versions.toml:
##
@@ -47,6 +47,7 @@ flink120 = { strictly = "1.20.0"}
google-libraries-bom = "26.47.0"
guava = "33.3.0-jre"
hadoop2 = "2.7.3"
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793744239
##
gradle/libs.versions.toml:
##
@@ -137,6 +139,7 @@ hadoop2-common = { module =
"org.apache.hadoop:hadoop-common", version.ref = "ha
hadoop2-hdfs = { module
RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793737541
##
.github/workflows/java-ci.yml:
##
@@ -108,7 +108,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
-jvm: [11, 17, 21]
+jvm
huaxingao commented on PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#issuecomment-2400917819
CI for preview1 passed.
CI for preview2 failed.
Trying SNAPSHOT to see if some of the Spark issues in preview2 have been
fixed in SNAPSHOT.
--
This is an automated message fr
huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1792517220
##
.github/workflows/java-ci.yml:
##
@@ -108,7 +108,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
-jvm: [11, 17, 21]
+jvm: [17
huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1792516517
##
.github/workflows/java-ci.yml:
##
@@ -95,7 +95,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
-jvm: [11, 17, 21]
+jvm: [17,
24 matches
Mail list logo
