RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793766774
##########
spark/v4.0/spark/src/main/scala/org/apache/spark/sql/stats/ThetaSketchAgg.scala:
##########
@@ -119,3 +122,12 @@ case class ThetaSketchAgg(
compactSketch.toByteArray
}
}
+
+object ThetaSketchAgg {
+ def expr(node: ColumnNode): Expression = {
+ node match {
+ case ExpressionColumnNode(expression, _) => expression
+ case node => throw SparkException.internalError("Unsupported ColumnNode:
" + node)
Review Comment:
Should we be throwing a Spark Internal error here? Seems like this our issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
