huaxingao commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1794321900
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownInRowLevelOperations.java:
##########
@@ -260,7 +267,12 @@ private void checkUpdate(RowLevelOperationMode mode,
String cond) {
DistributionMode.NONE.modeName());
Dataset<Row> changeDF =
spark.table(tableName).where(cond).limit(2).select("id");
- changeDF.coalesce(1).writeTo(tableName(CHANGES_TABLE_NAME)).create();
Review Comment:
I added the catch block to make the code compile for preview2. Preview1
doesn't need this. After switching to Preview2, I actually got a bunch of CI
failures due to `TableAlreadyExistsException` in a few test suites. Preview1
works fine. I am still trying to figure out which change between Preview1 and
Preview2 caused the behavior changes for `TableAlreadyExistsException`.
##########
spark/v4.0/spark/src/main/scala/org/apache/spark/sql/stats/ThetaSketchAgg.scala:
##########
@@ -119,3 +122,12 @@ case class ThetaSketchAgg(
compactSketch.toByteArray
}
}
+
+object ThetaSketchAgg {
+ def expr(node: ColumnNode): Expression = {
+ node match {
+ case ExpressionColumnNode(expression, _) => expression
+ case node => throw SparkException.internalError("Unsupported ColumnNode:
" + node)
Review Comment:
I will change this to an Iceberg Exception. I am not making the change in
this round because I want to try Preview 1 to see if the other changes can pass
the CI. I will fix this later when I try Preview 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
