HonahX merged PR #701:
URL: https://github.com/apache/iceberg-python/pull/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
HonahX commented on PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#issuecomment-2111753317
Looks like all the review comments are addressed. I'll merge this. Thanks
everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
frankliee commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1594885592
##
pyiceberg/catalog/hive.py:
##
@@ -111,6 +122,15 @@
HIVE2_COMPATIBLE = "hive.hive2-compatible"
HIVE2_COMPATIBLE_DEFAULT = False
+LOCK_CHECK_MIN_WAIT_TIME =
Fokko commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1594699293
##
pyiceberg/catalog/hive.py:
##
@@ -111,6 +122,15 @@
HIVE2_COMPATIBLE = "hive.hive2-compatible"
HIVE2_COMPATIBLE_DEFAULT = False
+LOCK_CHECK_MIN_WAIT_TIME = "lo
frankliee commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1592047115
##
pyiceberg/catalog/hive.py:
##
@@ -356,11 +371,46 @@ def _create_lock_request(self, database_name: str,
table_name: str) -> LockReque
return lock_r
frankliee commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1592047115
##
pyiceberg/catalog/hive.py:
##
@@ -356,11 +371,46 @@ def _create_lock_request(self, database_name: str,
table_name: str) -> LockReque
return lock_r
frankliee commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1591985541
##
tests/integration/test_reads.py:
##
@@ -506,3 +508,40 @@ def test_hive_locking(session_catalog_hive: HiveCatalog)
-> None:
table.transactio
frankliee commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1591970151
##
pyiceberg/catalog/hive.py:
##
@@ -356,6 +378,28 @@ def _create_lock_request(self, database_name: str,
table_name: str) -> LockReque
return lock_re
frankliee commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1591903957
##
pyiceberg/catalog/hive.py:
##
@@ -111,6 +122,13 @@
HIVE2_COMPATIBLE = "hive.hive2-compatible"
HIVE2_COMPATIBLE_DEFAULT = False
+DEFAULT_LOCK_CHECK_MIN_WAI
HonahX commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1591782640
##
pyiceberg/catalog/hive.py:
##
@@ -111,6 +122,13 @@
HIVE2_COMPATIBLE = "hive.hive2-compatible"
HIVE2_COMPATIBLE_DEFAULT = False
+DEFAULT_LOCK_CHECK_MIN_WAIT_T
HonahX commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1591768312
##
pyiceberg/catalog/hive.py:
##
@@ -356,11 +371,46 @@ def _create_lock_request(self, database_name: str,
table_name: str) -> LockReque
return lock_requ
frankliee commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1591771902
##
pyiceberg/catalog/hive.py:
##
@@ -111,6 +122,13 @@
HIVE2_COMPATIBLE = "hive.hive2-compatible"
HIVE2_COMPATIBLE_DEFAULT = False
+DEFAULT_LOCK_CHECK_MIN_WAI
HonahX commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1591764194
##
pyiceberg/catalog/hive.py:
##
@@ -111,6 +122,13 @@
HIVE2_COMPATIBLE = "hive.hive2-compatible"
HIVE2_COMPATIBLE_DEFAULT = False
+DEFAULT_LOCK_CHECK_MIN_WAIT_T
kevinjqliu commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1590382950
##
pyiceberg/catalog/hive.py:
##
@@ -111,6 +122,13 @@
HIVE2_COMPATIBLE = "hive.hive2-compatible"
HIVE2_COMPATIBLE_DEFAULT = False
+DEFAULT_LOCK_CHECK_MIN_WA
14 matches
Mail list logo
