frankliee commented on code in PR #701: URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1591903957
########## pyiceberg/catalog/hive.py: ########## @@ -111,6 +122,13 @@ HIVE2_COMPATIBLE = "hive.hive2-compatible" HIVE2_COMPATIBLE_DEFAULT = False +DEFAULT_LOCK_CHECK_MIN_WAIT_TIME = 2 +DEFAULT_LOCK_CHECK_MAX_WAIT_TIME = 30 +DEFAULT_LOCK_CHECK_RETRIES = 5 +DEFAULT_LOCK_CHECK_MULTIPLIER = 2 Review Comment: You are right, I have see this setting comes from HadoopConfiguration, "CatalogProperties" seems more suitable. https://github.com/apache/hive/blob/1b0e9d9758a0f28c4baf7b1895bf96bf11252f73/iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/MetastoreLock.java#L62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
