frankliee commented on code in PR #701:
URL: https://github.com/apache/iceberg-python/pull/701#discussion_r1592047115
##########
pyiceberg/catalog/hive.py:
##########
@@ -356,11 +371,46 @@ def _create_lock_request(self, database_name: str,
table_name: str) -> LockReque
return lock_request
- def _commit_table(self, table_request: CommitTableRequest) ->
CommitTableResponse:
+ def _wait_for_lock(
+ self, database_name: str, table_name: str, lockid: int, open_client:
Client, properties: Properties
+ ) -> LockResponse:
+ acquire_lock_timeout = (
+ properties.get(TableProperties.HIVE_ACQUIRE_LOCK_TIMEOUT_MS,
TableProperties.HIVE_ACQUIRE_LOCK_TIMEOUT_MS_DEFAULT)
+ ) / 1000.0
+ lock_check_min_wait_time = (
+ properties.get(TableProperties.HIVE_LOCK_CHECK_MIN_WAIT_MS,
TableProperties.HIVE_LOCK_CHECK_MIN_WAIT_MS_DEFAULT)
+ ) / 1000.0
+ lock_check_max_wait_time = (
+ properties.get(TableProperties.HIVE_LOCK_CHECK_MAX_WAIT_MS,
TableProperties.HIVE_LOCK_CHECK_MAX_WAIT_MS_DEFAULT)
+ ) / 1000.0
Review Comment:
I have added `property_as_float` to allow fine-grained control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
