github-actions[bot] closed pull request #10449: Hive: Return new scan after
applying column project parameter
URL: https://github.com/apache/iceberg/pull/10449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#issuecomment-2471993676
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#issuecomment-2458451811
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
pvary commented on code in PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#discussion_r1636140730
##
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##
@@ -125,11 +125,9 @@ public List getSplits(JobContext context) {
}
String sche
zhangbutao commented on code in PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#discussion_r1635749793
##
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##
@@ -125,11 +125,9 @@ public List getSplits(JobContext context) {
}
String
zhangbutao commented on code in PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#discussion_r1635743782
##
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##
@@ -125,11 +125,9 @@ public List getSplits(JobContext context) {
}
String
pvary commented on code in PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#discussion_r1635167684
##
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##
@@ -125,11 +125,9 @@ public List getSplits(JobContext context) {
}
String sche
zhangbutao commented on code in PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#discussion_r1634220405
##
mr/src/test/java/org/apache/iceberg/mr/TestIcebergInputFormats.java:
##
@@ -234,6 +234,8 @@ public void testProjection() throws Exception {
Schema projec
pvary commented on code in PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#discussion_r1632746388
##
mr/src/test/java/org/apache/iceberg/mr/TestIcebergInputFormats.java:
##
@@ -234,6 +234,8 @@ public void testProjection() throws Exception {
Schema projection
zhangbutao commented on code in PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#discussion_r1629227339
##
mr/src/test/java/org/apache/iceberg/mr/TestIcebergInputFormats.java:
##
@@ -234,6 +234,8 @@ public void testProjection() throws Exception {
Schema projec
pvary commented on PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#issuecomment-2151612132
> I am not sure how to add the test & also think no need add the test.
I disagree with you here because of 2 reasons:
1. If there is no tests, then how can we be sure that fut
zhangbutao commented on PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#issuecomment-2151496203
> @zhangbutao: Could you please provide a test case which fails without the
patch and runs correctly with the patch?
@pvary Thanks for you comment. Actually, there are no faile
pvary commented on PR #10449:
URL: https://github.com/apache/iceberg/pull/10449#issuecomment-2150699009
@zhangbutao: Could you please provide a test case which fails without the
patch and runs correctly with the patch?
--
This is an automated message from the Apache Git Service.
To respon
13 matches
Mail list logo
