zhangbutao commented on PR #10449: URL: https://github.com/apache/iceberg/pull/10449#issuecomment-2151496203
> @zhangbutao: Could you please provide a test case which fails without the patch and runs correctly with the patch? @pvary Thanks for you comment. Actually, there are no failed tests without this change. I am not sure how to add the test & also think no need add the test. 1. First, `scan.project() `& `scan.select` is a optimization for reducing some column scanning, before this change, we never use the new scan but this won't result in failure; after the change, we use the new scan which can optimize some else stuff. 2. Second, `scan.project()` & `scan.select` can not be specified at the same time, see this test https://github.com/apache/iceberg/pull/1353/files#diff-a94dee2a22a2890689a84529a978a769bdc3b084f35d79caf9608d49b2e1cc1b Before this change, `scan.project()` is never used in hive implementation, and you can check the `InputFormatConfig.READ_SCHEMA` which never been assigned a value, so we nerver get a failed test when `scan.project() `& `scan.select` both exist. Thanks. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
