pvary commented on code in PR #10449: URL: https://github.com/apache/iceberg/pull/10449#discussion_r1632746388
########## mr/src/test/java/org/apache/iceberg/mr/TestIcebergInputFormats.java: ########## @@ -234,6 +234,8 @@ public void testProjection() throws Exception { Schema projection = TypeUtil.select(SCHEMA, ImmutableSet.of(1)); builder.project(projection); + // project() is the first to be applied on scan, so the select() won't take effect. + builder.select("id"); Review Comment: @zhangbutao: That test would be great - it would test if setting `select` and `project` both working! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org