Re: [PR] Hive: Fix metadata file not found [iceberg]

nastra merged PR #10069: URL: https://github.com/apache/iceberg/pull/10069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Hive: Fix metadata file not found [iceberg]

lurnagao-dahua commented on code in PR #10069: URL: https://github.com/apache/iceberg/pull/10069#discussion_r1549380381 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java: ## @@ -397,6 +397,30 @@ public void testLockExceptionUnknownSuccessCommit() throw

Re: [PR] Hive: Fix metadata file not found [iceberg]

nastra commented on code in PR #10069: URL: https://github.com/apache/iceberg/pull/10069#discussion_r1549340231 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java: ## @@ -397,6 +397,30 @@ public void testLockExceptionUnknownSuccessCommit() throws TExce

Re: [PR] Hive: Fix metadata file not found [iceberg]

lurnagao-dahua commented on PR #10069: URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2033989359 > @lurnagao-dahua: If you check https://github.com/apache/iceberg/blob/3caa3a28d07a2d08b9a0e4196634126f1e016d6a/hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommit

Re: [PR] Hive: Fix metadata file not found [iceberg]

pvary commented on PR #10069: URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2033649191 @lurnagao-dahua: If you check https://github.com/apache/iceberg/blob/3caa3a28d07a2d08b9a0e4196634126f1e016d6a/hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java, yo

Re: [PR] Hive: Fix metadata file not found [iceberg]

lurnagao-dahua commented on PR #10069: URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2033424821 Thank you for your response! In my case flink streaming write to iceberg 1.Hive metastore has been full GC continuously so it will throw SocketTimeoutException: Read timed

Re: [PR] Hive: Fix metadata file not found [iceberg]

lurnagao-dahua commented on PR #10069: URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2032193393 > @lurnagao-dahua please check styles. > > > The reason is that in some cases, the e.getMessage() return null and it will throw NullPointerException, then skip checkCommitS

Re: [PR] Hive: Fix metadata file not found [iceberg]

lurnagao-dahua commented on PR #10069: URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2032181736 > @lurnagao-dahua请检查样式。 > > > 原因是在某些情况下，e.getMessage()返回null，会抛出NullPointerException，然后跳过checkCommitStatus，可能是删除metadataLocation，实际上元数据提交成功。 > > 是否可以为这种情况添加 UT？

Re: [PR] Hive: Fix metadata file not found [iceberg]

lurnagao-dahua closed pull request #10069: Hive: Fix metadata file not found URL: https://github.com/apache/iceberg/pull/10069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Hive: Fix metadata file not found [iceberg]

manuzhang commented on PR #10069: URL: https://github.com/apache/iceberg/pull/10069#issuecomment-2031250719 @lurnagao-dahua please check styles. > The reason is that in some cases, the e.getMessage() return null and it will throw NullPointerException, then skip checkCommitStatus, it

Re: [PR] Hive: Fix metadata file not found [iceberg]

manuzhang commented on code in PR #10069: URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547262874 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata

Re: [PR] Hive: Fix metadata file not found [iceberg]

manuzhang commented on code in PR #10069: URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547262874 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata

Re: [PR] Hive: Fix metadata file not found [iceberg]

manuzhang commented on code in PR #10069: URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547262874 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata

Re: [PR] Hive: Fix metadata file not found [iceberg]

pvary commented on code in PR #10069: URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547189727 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata meta

Re: [PR] Hive: Fix metadata file not found [iceberg]

manuzhang commented on code in PR #10069: URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547080134 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata