manuzhang commented on code in PR #10069:
URL: https://github.com/apache/iceberg/pull/10069#discussion_r1547262874
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -263,8 +263,8 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
throw e;
} catch (Throwable e) {
- if (e.getMessage()
- .contains(
+ if (e.getMessage() != null
Review Comment:
If we had the method in the first place, I don't think we would miss the
null check here. With this method, we can ensure the null check will be applied
in any other places. Just my two cents, which should not block this PR from
being merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
