Re: [PR] Glue endpoint config variable [iceberg-python]

2024-07-12 Thread via GitHub
sebpretzer commented on PR #530: URL: https://github.com/apache/iceberg-python/pull/530#issuecomment-2225579524 Close in favor of https://github.com/apache/iceberg-python/pull/920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Glue endpoint config variable [iceberg-python]

2024-07-12 Thread via GitHub
sebpretzer closed pull request #530: Glue endpoint config variable URL: https://github.com/apache/iceberg-python/pull/530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Glue endpoint config variable [iceberg-python]

2024-07-09 Thread via GitHub
HonahX commented on PR #530: URL: https://github.com/apache/iceberg-python/pull/530#issuecomment-2219498216 Hi @sebpretzer. Gently checking in to see if you have time to update this PR. If not, I’d be happy to help and take over the changes. It will be great to include this in 0.7.0 -- T

Re: [PR] Glue endpoint config variable [iceberg-python]

2024-03-19 Thread via GitHub
HonahX commented on PR #530: URL: https://github.com/apache/iceberg-python/pull/530#issuecomment-2008641566 @sebpretzer FYI, I just found an error in the current glue integration test: #536 . Please feel free to include this fix in this PR if you want to add `glue.endpoint` to the integrati

Re: [PR] Glue endpoint config variable [iceberg-python]

2024-03-19 Thread via GitHub
HonahX commented on code in PR #530: URL: https://github.com/apache/iceberg-python/pull/530#discussion_r1531398064 ## tests/catalog/test_glue.py: ## @@ -692,3 +692,11 @@ def test_commit_table_properties( updated_table_metadata = table.metadata assert test_catalog._pars

Re: [PR] Glue endpoint config variable [iceberg-python]

2024-03-19 Thread via GitHub
Fokko commented on PR #530: URL: https://github.com/apache/iceberg-python/pull/530#issuecomment-2006080178 > On my end, I am using glue.endpoint for all pytests. I was not sure if within pyiceberg pytests, we wanted to migrate all tests to the endpoint, or continue to use mock_aws(). I star

Re: [PR] Glue endpoint config variable [iceberg-python]

2024-03-18 Thread via GitHub
Fokko commented on code in PR #530: URL: https://github.com/apache/iceberg-python/pull/530#discussion_r1529322025 ## pyiceberg/catalog/glue.py: ## @@ -105,6 +105,10 @@ GLUE_SKIP_ARCHIVE = "glue.skip-archive" GLUE_SKIP_ARCHIVE_DEFAULT = True +# Configure an alternative endpoi