HonahX commented on code in PR #530:
URL: https://github.com/apache/iceberg-python/pull/530#discussion_r1531398064
##########
tests/catalog/test_glue.py:
##########
@@ -692,3 +692,11 @@ def test_commit_table_properties(
updated_table_metadata = table.metadata
assert test_catalog._parse_metadata_version(table.metadata_location) == 1
assert updated_table_metadata.properties == {"test_a": "test_aa",
"test_c": "test_c"}
+
+
+def test_glue_endpoint_override(moto_endpoint_url: str, database_name: str) ->
None:
+ catalog_name = "glue"
+ test_catalog = GlueCatalog(
+ catalog_name, **{"s3.endpoint": moto_endpoint_url, "warehouse":
f"s3://{BUCKET_NAME}", "glue.endpoint": moto_endpoint_url}
+ )
+ assert test_catalog.glue.meta.endpoint_url == moto_endpoint_url
Review Comment:
[Optional]Since we don't call any glue API in this test, shall we just use a
fake endpoint url which is more explicit instead of the moto's?
Like
```python
test_endpoint = "this_is_a_test_endpoint"
.....
assert test_catalog.glue.meta.endpoint_url == test_endpoint
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
