Fokko commented on PR #530:
URL: https://github.com/apache/iceberg-python/pull/530#issuecomment-2006080178

   > On my end, I am using glue.endpoint for all pytests. I was not sure if 
within pyiceberg pytests, we wanted to migrate all tests to the endpoint, or 
continue to use mock_aws(). I started with the least invasive option, but can 
migrate all other glue tests if that is helpful.
   
   I'm not a big fan of mocking, but I'll defer this question to @HonahX since 
he's the main author.
   
   > I am not seeing a ton of docs regarding glue config variables, and its is 
undocumented in [the main docs](https://iceberg.apache.org/docs/latest/). 
Within pyiceberg docs, I do see [this Glue 
config](https://py.iceberg.apache.org/configuration/#glue-catalog), but not 
sure if this is the best place to put it. Should this get added to the docs, or 
should it remain undocumented, since its not a commonly used feature?
   
   Not documenting features is a mistake, we should document everything as much 
as possible, without losing the end-user :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to