pvary commented on PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#issuecomment-2079121401
Merged to master.
Thanks for the review @stevenzwu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
pvary merged PR #10208:
URL: https://github.com/apache/iceberg/pull/10208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
stevenzwu commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1579871219
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##
@@ -40,24 +44,27 @@
import org.apache.iceberg.FileFormat;
im
pvary commented on PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#issuecomment-2076940629
Are we good to go with this @stevenzwu ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
pvary commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1577734223
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailoverWithWatermarkExtractor.java:
##
@@ -88,16 +88,11 @@ protected void assertRec
pvary commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1577733915
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java:
##
@@ -284,11 +284,7 @@ public static void assertRecordsEqual(List
expected, List actu
pvary commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1577692634
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##
@@ -40,24 +44,27 @@
import org.apache.iceberg.FileFormat;
import
pvary commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1577691189
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##
@@ -149,6 +163,15 @@ private void testBoundedIcebergSource(Failove
pvary commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1577690466
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##
@@ -201,8 +201,11 @@ private SplitEnumerator createEnumer
return new Co
pvary commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1576638673
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##
@@ -40,24 +44,27 @@
import org.apache.iceberg.FileFormat;
import
stevenzwu commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1576552272
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##
@@ -201,8 +201,11 @@ private SplitEnumerator createEnumer
return ne
11 matches
Mail list logo
