pvary commented on code in PR #10208:
URL: https://github.com/apache/iceberg/pull/10208#discussion_r1577733915


##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java:
##########
@@ -284,11 +284,7 @@ public static void assertRecordsEqual(List<Record> 
expected, List<Record> actual
   public static void assertTableRecords(Table table, List<Record> expected, 
Duration timeout) {
     Awaitility.await("expected list of records should be produced")
         .atMost(timeout)
-        .untilAsserted(
-            () -> {
-              equalsRecords(expected, tableRecords(table), table.schema());

Review Comment:
   This does not do anything. The method is just an "equals" implementation, 
but the result is not used anywhere.
   So I removed the call.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to