Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

sungwy commented on PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#issuecomment-2302976618 > Thanks! Most changes look good to me. Here are some nits. Hi @Xuanwo - Given that there's an outstanding issue with the submodules, I decided to just implement a class and stati

Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

sungwy commented on code in PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1725497415 ## bindings/python/src/transform.rs: ## @@ -0,0 +1,75 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. S

Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

Xuanwo commented on code in PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1724448667 ## bindings/python/src/transform.rs: ## @@ -0,0 +1,75 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. S

Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

sungwy commented on PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#issuecomment-2297298410 Thank you for the reviews @Xuanwo - I've taken all of your feedback and refactored the code to use the arrow::pyarrow crate -- This is an automated message from the Apache Git Service

Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

sungwy commented on code in PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1722066450 ## .github/workflows/bindings_python_ci.yml: ## @@ -78,6 +78,6 @@ jobs: shell: bash run: | set -e - pip install dist/pyiceberg_c

Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

Xuanwo commented on code in PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1721162878 ## bindings/python/src/transform.rs: ## @@ -0,0 +1,142 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

sungwy commented on code in PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1720311292 ## bindings/python/pyproject.toml: ## @@ -31,8 +31,30 @@ classifiers = [ "Programming Language :: Python :: 3.12", ] -[project.optional-dependencies] -test = ["

Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

sungwy commented on code in PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1720136976 ## bindings/python/pyproject.toml: ## @@ -31,8 +31,30 @@ classifiers = [ "Programming Language :: Python :: 3.12", ] -[project.optional-dependencies] -test = ["

Re: [PR] Expose Bucket Transform to Python Binding [iceberg-rust]

sungwy commented on code in PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1720136976 ## bindings/python/pyproject.toml: ## @@ -31,8 +31,30 @@ classifiers = [ "Programming Language :: Python :: 3.12", ] -[project.optional-dependencies] -test = ["