sungwy commented on PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#issuecomment-2302976618
> Thanks! Most changes look good to me. Here are some nits. Hi @Xuanwo - Given that there's an outstanding issue with the submodules, I decided to just implement a class and staticmethods instead so that we can make use of the usage pattern proposed in the tests. Please let me know what you think. I've added the conversions for all of the existing transforms for completeness. The test suite prioritizes verifying the integration, rather than the correctness of the transformed values which is already verified in the rust based test suites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
