sungwy commented on code in PR #556: URL: https://github.com/apache/iceberg-rust/pull/556#discussion_r1720136976
########## bindings/python/pyproject.toml: ########## @@ -31,8 +31,30 @@ classifiers = [ "Programming Language :: Python :: 3.12", ] -[project.optional-dependencies] -test = ["pytest"] +# Duplicate section required: https://github.com/python-poetry/poetry/pull/9135 Review Comment: There's an open item to allow poetry to use [project] section instead of [tool.poetry] I'm exploring using poetry for dependency management because even installing test dependencies is starting to feel a little strange with a simple pyproject.toml file, since we need to maintain a separate list of dependencies in `.github/workflows/bindings_python_ci.yml` as well as in bindings/python/pyproject.toml (there's no way to install just the optional dependencies using pip or maturin, it only supports editable install of the root project in addition to the extra dependencies). But this duplication of the two very similar sections ([project] for maturin, and [tool.poetry] for poetry) also feels suboptimal... We could also exploring using other python dependency managers as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
