findepi commented on PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2412095546
thank you @RussellSpitzer for your review.
i think this one could deserve a fix:
https://github.com/apache/iceberg/issues/10493
--
This is an automated message from the Apache Git
RussellSpitzer commented on PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2411973324
@findepi This seems like a great find, is there anything we need to do right
now though? I just want to make sure we aren't leaving open any issues by only
marking it as deprecat
findepi commented on PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2238718531
BTW Trino challenges around cache invalidation led me to believe this topic
is complex and deserving a presentation. there was one at the [Trino summit
2023](https://trino.io/blog/2023/
findepi commented on PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2231835456
@amogh-jahagirdar please take another look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jbonofre commented on code in PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#discussion_r1643348264
##
core/src/main/java/org/apache/iceberg/io/ContentCache.java:
##
@@ -147,10 +147,23 @@ public InputFile tryCache(InputFile input) {
return input;
}
+ /**
Fokko commented on code in PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#discussion_r1643337565
##
core/src/main/java/org/apache/iceberg/io/ContentCache.java:
##
@@ -147,10 +147,23 @@ public InputFile tryCache(InputFile input) {
return input;
}
+ /**
+
findepi commented on code in PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#discussion_r1643023850
##
core/src/main/java/org/apache/iceberg/io/ContentCache.java:
##
@@ -147,10 +147,23 @@ public InputFile tryCache(InputFile input) {
return input;
}
+ /**
ajantha-bhat commented on code in PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#discussion_r1642819432
##
core/src/main/java/org/apache/iceberg/io/ContentCache.java:
##
@@ -147,10 +147,23 @@ public InputFile tryCache(InputFile input) {
return input;
}
+
findepi commented on code in PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#discussion_r1642484939
##
core/src/main/java/org/apache/iceberg/io/ContentCache.java:
##
@@ -147,10 +147,23 @@ public InputFile tryCache(InputFile input) {
return input;
}
+ /**
jbonofre commented on code in PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#discussion_r1641622578
##
core/src/main/java/org/apache/iceberg/io/ContentCache.java:
##
@@ -147,10 +147,23 @@ public InputFile tryCache(InputFile input) {
return input;
}
+ /**
findepi commented on PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2168612952
@rizaon thank you for your feedback!
> Although, I think it is less of an issue in Iceberg since Iceberg manifest
files are immutable?
Good point, I also thought about this
rizaon commented on PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2168593729
Hi @findepi, thank you for looking into this.
https://github.com/google/guava/issues/1881 also came to my attention recently
in an [Impala code
review](https://gerrit.cloudera.org/c/208
findepi commented on PR #10494:
URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2168490131
cc @rizaon @szehon-ho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
13 matches
Mail list logo
