rizaon commented on PR #10494: URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2168593729
Hi @findepi, thank you for looking into this. https://github.com/google/guava/issues/1881 also came to my attention recently in an [Impala code review](https://gerrit.cloudera.org/c/20853/#message-236b0d76_69b85726). I don't mind marking `invalidateAll` as deprecated and remove it later. Impala does not actively call this method and relies on time and byte based eviction. https://github.com/apache/impala/blob/9f5fbcd841a87b144f3410891fe6bf1f8fe4288c/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py#L129-L134 Although, I think it is less of an issue in Iceberg since Iceberg manifest files are immutable? Can you also review if `ManifestFiles.dropCache` is safe? Maybe we can document that dropping the whole ContentCache should achieve the same goal as `ContentCache.invalidateAll`. https://github.com/apache/iceberg/blob/74cf6977b9db46df2850f29d099764d76950b6a2/core/src/main/java/org/apache/iceberg/ManifestFiles.java#L83-L87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
