findepi commented on PR #10494: URL: https://github.com/apache/iceberg/pull/10494#issuecomment-2168612952
@rizaon thank you for your feedback! > Although, I think it is less of an issue in Iceberg since Iceberg manifest files are immutable? Good point, I also thought about this. The ContentCache class is designed as generic purpose cache of file contents. Given immutability, we shouldn't need invalidation at all. > Can you also review if `ManifestFiles.dropCache` is safe? Thanks for asking! I don't see a problem with that method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
