Re: [PR] Core:Simplify newTableMetadata method in TableMetadata class [iceberg]

2024-06-18 Thread via GitHub
nastra merged PR #10528: URL: https://github.com/apache/iceberg/pull/10528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core:Simplify newTableMetadata method in TableMetadata class [iceberg]

2024-06-18 Thread via GitHub
nastra commented on code in PR #10528: URL: https://github.com/apache/iceberg/pull/10528#discussion_r1644157445 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -74,11 +74,7 @@ public static TableMetadata newTableMetadata( public static TableMetadata newTabl

Re: [PR] Core:Simplify newTableMetadata method in TableMetadata class [iceberg]

2024-06-18 Thread via GitHub
nastra commented on code in PR #10528: URL: https://github.com/apache/iceberg/pull/10528#discussion_r1644064255 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -74,11 +74,7 @@ public static TableMetadata newTableMetadata( public static TableMetadata newTabl

Re: [PR] Core:Simplify newTableMetadata method in TableMetadata class [iceberg]

2024-06-18 Thread via GitHub
DaqianLiao commented on code in PR #10528: URL: https://github.com/apache/iceberg/pull/10528#discussion_r1643939337 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -74,11 +74,7 @@ public static TableMetadata newTableMetadata( public static TableMetadata new

Re: [PR] Core:Simplify newTableMetadata method in TableMetadata class [iceberg]

2024-06-17 Thread via GitHub
wangyinsheng commented on code in PR #10528: URL: https://github.com/apache/iceberg/pull/10528#discussion_r1643914605 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -74,11 +74,7 @@ public static TableMetadata newTableMetadata( public static TableMetadata n

Re: [PR] Core:Simplify newTableMetadata method in TableMetadata class [iceberg]

2024-06-17 Thread via GitHub
wangyinsheng commented on code in PR #10528: URL: https://github.com/apache/iceberg/pull/10528#discussion_r1643914605 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -74,11 +74,7 @@ public static TableMetadata newTableMetadata( public static TableMetadata n