wangyinsheng commented on code in PR #10528:
URL: https://github.com/apache/iceberg/pull/10528#discussion_r1643914605
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -74,11 +74,7 @@ public static TableMetadata newTableMetadata(
public static TableMetadata newTableMetadata(
Schema schema, PartitionSpec spec, String location, Map<String, String>
properties) {
SortOrder sortOrder = SortOrder.unsorted();
- int formatVersion =
- PropertyUtil.propertyAsInt(
- properties, TableProperties.FORMAT_VERSION,
DEFAULT_TABLE_FORMAT_VERSION);
- return newTableMetadata(
- schema, spec, sortOrder, location, persistedProperties(properties),
formatVersion);
+ return newTableMetadata(schema, spec, sortOrder, location,
persistedProperties(properties));
Review Comment:
No need to call persistedProperties here, it has already been invoked
internally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
