wangyinsheng commented on code in PR #10528:
URL: https://github.com/apache/iceberg/pull/10528#discussion_r1643914605
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -74,11 +74,7 @@ public static TableMetadata newTableMetadata(
public static TableMetadata newTableMetadata(
Schema schema, PartitionSpec spec, String location, Map<String, String>
properties) {
SortOrder sortOrder = SortOrder.unsorted();
- int formatVersion =
- PropertyUtil.propertyAsInt(
- properties, TableProperties.FORMAT_VERSION,
DEFAULT_TABLE_FORMAT_VERSION);
- return newTableMetadata(
- schema, spec, sortOrder, location, persistedProperties(properties),
formatVersion);
+ return newTableMetadata(schema, spec, sortOrder, location,
persistedProperties(properties));
Review Comment:
No need to call `persistedProperties` here, it will been invoked internally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
